Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( Note: This branch is done on top of #14 . Once you apply #14 , this PR will contain only 1 commit. )
The
TOpenGLView.defaultPixelFormat
declares local arraybut this size is too small. The code inside the
TOpenGLView.defaultPixelFormat
wants this list to have at least size of 10, looking at various linesattributes[Inc(i)] := ...
. It currently crashes, as even the default execution needs more size than 5.I looked at fork from @genericptr and followed the solution from there ( https://github.com/genericptr/GLPT/blob/16dcec0a632dfeed0bcb0b07938a0a2fc16490be/include/GLPT_Cocoa.inc#L654 ):
This means size 33, safely more than we need.
Note: I found this error while testing Cocoa integration code. I tested it by running GLPT examples, and also because I was basing Cocoa backend of TCastleWindow in Castle Game Engine on GLPT code. See https://castle-engine.io/wp/2022/05/29/huge-improvements-for-macos-users-macos-binary-beta-release-cocoa-backend-for-tcastlewindow-automatic-running-and-packing-using-appbundle-access-to-macos-thanks-to-macstadium/ and https://github.com/castle-engine/castle-engine/blob/master/src/window/castlewindow_cocoa.inc about Cocoa+Castle Game Engine. Thank you very much for creating GLPT, I appreciate greatly that I could use a lot of GLPT code to have a ready solution in CGE.